Skip to content

[Sync] Update project files from source repository (ffbafef)#34

Merged
mrz1836 merged 1 commit into
mainfrom
chore/sync-files-bsv-blockchain-services-20260320-120855-ffbafef
Mar 20, 2026
Merged

[Sync] Update project files from source repository (ffbafef)#34
mrz1836 merged 1 commit into
mainfrom
chore/sync-files-bsv-blockchain-services-20260320-120855-ffbafef

Conversation

@mrz1836
Copy link
Copy Markdown
Collaborator

@mrz1836 mrz1836 commented Mar 20, 2026

What Changed

  • Updated minimum Go version requirement from 1.23 to 1.25 throughout the setup-benchstat GitHub Action
  • Modified version check logic to verify Go version >= 1.25 instead of >= 1.23
  • Updated all documentation strings, descriptions, and example version numbers from "1.23"/"1.24.x" to "1.25"/"1.26.x"
  • Changed version comparison condition from [ "$MINOR" -lt 23 ] to [ "$MINOR" -lt 25 ]

Why It Was Necessary

  • Benchstat tool now requires a newer minimum Go version (1.25+) to function properly
  • Documentation and validation logic needed to be synchronized with the updated dependency requirements
  • Version compatibility checks must prevent installation attempts on incompatible Go versions to avoid build failures

Testing Performed

  • Verified version parsing logic correctly identifies Go 1.25+ as compatible
  • Tested that Go versions < 1.25 trigger the skip condition with appropriate warning messages
  • Confirmed all error messages and user-facing documentation reflect the new version requirement

Impact / Risk

  • Breaking Change: Workflows using Go versions 1.23 or 1.24 will now skip benchstat installation instead of proceeding
  • Risk: Low - version check gracefully skips installation rather than failing, and outputs clearly indicate the skip reason
  • Developer Impact: Teams must upgrade to Go 1.25+ to utilize benchstat functionality in their CI/CD pipelines

@mrz1836 mrz1836 self-assigned this Mar 20, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Mar 20, 2026
@github-actions github-actions Bot added size/M Medium change (51–200 lines) update General updates labels Mar 20, 2026
@mrz1836 mrz1836 merged commit df09cd3 into main Mar 20, 2026
43 of 45 checks passed
@github-actions github-actions Bot deleted the chore/sync-files-bsv-blockchain-services-20260320-120855-ffbafef branch March 20, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/M Medium change (51–200 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant